Add settings for inline styles in modPHPMailer #16791
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds 2 new system settings:
mail_inlinestyle_inline(yes/no) – default yes (existing behavior)mail_inlinestyle_remove_style_tags(yes/no) – default no (this is a change in behavior, but also fixes current unexpected behavior - see discussion in E-Mail: InlineStyle removes style tags, making responsive email impossible #16715 )Why is it needed?
Fixes issues with
<style>tags in HTML email templates and gives website owners more control. Styles should be inlined but<style>tags should be left in the markup and not removed. This is needed for example for email templates that involve media queries.How to test
See #16715
Related issue(s)/PR(s)
Resolves #16715