Add support for Rails 8.1 #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankimio
commented
Nov 6, 2025
Comment on lines
128
to
136
| # Persist only real DB columns; exclude synthesized custom_sql aliases | ||
| def column_names | ||
| connection.schema_cache.columns_hash(table_name).keys | ||
| end | ||
|
|
||
| # Ensure columns list reflects only real DB columns | ||
| def columns | ||
| connection.schema_cache.columns(table_name) | ||
| end |
Author
There was a problem hiding this comment.
ensure only real columns are updated when using motor admin UI
dankimio
commented
Nov 6, 2025
Comment on lines
-126
to
-133
| else | ||
| ActiveRecord::ConnectionAdapters::Column.new( | ||
| column[:name], | ||
| nil, | ||
| ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: column[:column_type], | ||
| type: column[:column_type].to_sym) | ||
| ) | ||
| end |
…atible with file uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #200
this PR drops support for 7.1 column synthesizing
@omohokcoj curious to hear your thoughts since i have limited understanding of what's going on