Skip to content

Conversation

@sappelhoff
Copy link
Contributor

Most important changes here are:

  • removing an unused and undocumented name parameter in the __init__ function of the ASR class
  • properly passing the documented memory key word argument to __init__
  • As the two above changes are breaking, I made the init of the ASR class key word only, using the asterisk notation

@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.87%. Comparing base (e44c4bb) to head (d5ba50f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   82.86%   82.87%   +0.01%     
==========================================
  Files          25       25              
  Lines        2813     2815       +2     
==========================================
+ Hits         2331     2333       +2     
  Misses        482      482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sappelhoff
Copy link
Contributor Author

@nbara this is ready for a review 🙂

@nbara nbara changed the title ASR: fix docstrs, make init kwarg required, fix name and memory kws [FIX] ASR: fix docstrs, make init kwarg required, fix name and memory kws Jun 12, 2025
@nbara nbara changed the title [FIX] ASR: fix docstrs, make init kwarg required, fix name and memory kws [FIX] ASR fixes Jun 12, 2025
@nbara
Copy link
Owner

nbara commented Jun 12, 2025

Thanks @sappelhoff , just this one change and we're good to go

Co-authored-by: Nicolas Barascud <nicolas.barascud@gmail.com>
@nbara nbara merged commit 5a9a826 into nbara:master Jun 15, 2025
7 checks passed
@nbara
Copy link
Owner

nbara commented Jun 15, 2025

Thanks @sappelhoff

@nbara nbara added the bug Something isn't working label Jun 15, 2025
@sappelhoff sappelhoff deleted the minor branch June 16, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants