update packages to work with latest node LTS version #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ciao Riccardo =)
I wanted to discuss the possibility to update
onepunchto the latest LTS version of node (at the time of writing: Gallium, 16.17.0). This would mean breaking onepunch for node versions prior to version 14, but I think it's an inevitable choice if onepunch needs to be up to date security-wise.I tried to test as much as possible various scenarios and I think I was able to adapt the code to make it work with the updated packages. Let me know though if you find anything that is still not working or if you think that something could be done differently.
Here is a list of the things I did:
live-serverwas not updated anymore, so switched toalive-server, which is just an updated fork off of that;.prettierrc.jsonfile just to create a standard for coding styles so thatxowould not throw errors during linting testsxolinting was suggesting changes