-
-
Notifications
You must be signed in to change notification settings - Fork 504
feat: add a way to provide an axios instance #2423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jdrouet
wants to merge
2
commits into
orval-labs:master
Choose a base branch
from
jdrouet:jdrouet/axios-instance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
this looks pretty good to me build is running now |
Collaborator
|
sorry do a git pull from main please |
Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
21687c4 to
4b4ccfa
Compare
Author
|
I rebased 😉 |
Collaborator
|
running build again |
Collaborator
|
ok it looks like it is failing the samples check you might want to run |
Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
Author
|
@melloware should be fixed now 🤔 |
Collaborator
|
|
Author
|
I will come with a proper fix today or tomorrow 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
axiosclient, I'd like to be able to provide an axios instance. The way to do in the doc is to define a global constant which is then used globally. This is a problem because it allows only a single instance of the client in the application and it's potentially prone to security issues.With this, we can create an instance of axios an pass it as an argument like the following
Fix #653