Skip to content

Conversation

@Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Dec 1, 2025

CleanShot 2025-12-01 at 17 15 56@2x

Copilot AI review requested due to automatic review settings December 1, 2025 09:12
@Brooooooklyn Brooooooklyn requested a review from camc314 as a code owner December 1, 2025 09:12
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request labels Dec 1, 2025
Copy link
Member Author

Brooooooklyn commented Dec 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot finished reviewing on behalf of Brooooooklyn December 1, 2025 09:13
@Brooooooklyn Brooooooklyn force-pushed the 12-01-feat_lint_fmt_generate_config_types_from_json_schema branch from 1743c7e to 88f3bdc Compare December 1, 2025 09:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds automated TypeScript type generation from JSON schemas for both oxlint and oxfmt configuration files using the quicktype-core library. The feature enhances type safety by generating TypeScript definitions (config.d.ts) from JSON schemas during the build process.

  • Adds quicktype-core v23.2.6 as a catalog dependency
  • Implements JSON schema to TypeScript type generation in build scripts
  • Generates config.d.ts files for both oxlint and oxfmt configurations

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-workspace.yaml Adds quicktype-core ^23.2.6 to the workspace catalog
pnpm-lock.yaml Updates lockfile with quicktype-core and its dependencies
apps/oxlint/scripts/build.ts Adds quicktype integration to generate TypeScript types from JSON schema
apps/oxlint/package.json References quicktype-core from catalog as devDependency
apps/oxfmt/scripts/build.js Adds quicktype integration similar to oxlint build script
apps/oxfmt/package.json References quicktype-core from catalog as devDependency
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

apps/oxlint/scripts/build.ts:69

  • [nitpick] Missing trailing comma after the rendererOptions object. This is inconsistent with the oxfmt build script (build.js:79) which includes a trailing comma. Add a trailing comma for consistency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Brooooooklyn and others added 3 commits December 1, 2025 17:19
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: LongYinan <lynweklm@gmail.com>
@Brooooooklyn Brooooooklyn force-pushed the 12-01-feat_lint_fmt_generate_config_types_from_json_schema branch from 2ae2cb7 to b847ac7 Compare December 1, 2025 09:19
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: we want to add configuration support to vite+ config.

This aligns with #15913, but before that lands this sounds like a temporary solution.

@Boshen Boshen marked this pull request as draft December 1, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants