fix(oxlint/lsp): revalidate all known files after internal restart

[Sysix]

Before:
Linted all files which are not ignored & supported
After:
Lint all files which are got open inside the editor

[Sysix]

• fix(lsp): shutdown a WorkspaceWorker will clear diagnostics for all known files #16467
• perf(lsp): avoid Uri to String and back to Uri conversion #16470
• perf(lsp): avoid cloning when revalidating diagnostics #16469
• fix(oxlint/lsp): revalidate all known files after internal restart #16407 👈 (View in Graphite)
• test(lsp): add tests for diagnostics on didOpen|didChange|didSave #16466
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR modifies the language server to revalidate only files currently open in the editor when internal tool restarts occur (such as configuration changes or config file updates), rather than revalidating all files that have previously been linted.

Key changes:

• Thread LSPFileSystem parameter through tool restart methods to access currently open files
• Replace cached diagnostics file list with file system keys for revalidation
• Remove file system entry removal on file save

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_language_server/src/worker.rs	Added file_system parameter to did_change_watched_files and did_change_configuration methods; updated test calls to pass LSPFileSystem::default()
crates/oxc_language_server/src/tool.rs	Added file_system: &LSPFileSystem parameter to handle_configuration_change and handle_watched_file_change trait methods
crates/oxc_language_server/src/tests.rs	Updated FakeTool implementation to accept new file_system parameter
crates/oxc_language_server/src/linter/tester.rs	Updated test helper to pass LSPFileSystem::default() to configuration change method
crates/oxc_language_server/src/linter/server_linter.rs	Changed revalidation to use file_system.keys() instead of get_cached_files_of_diagnostics() to only revalidate open files
crates/oxc_language_server/src/formatter/tester.rs	Updated test helper to pass LSPFileSystem::default() to configuration change method
crates/oxc_language_server/src/formatter/server_formatter.rs	Added unused _file_system parameter to trait method implementations
crates/oxc_language_server/src/backend.rs	Passed file system reference to worker methods; removed file system entry removal on save

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

crates/oxc_language_server/src/backend.rs:511

• The removal of self.file_system.write().await.remove(uri) from this method can cause stale in-memory content to be used during tool restarts.

If the server's save capability doesn't include includeText: true (meaning params.text will be None), the file is saved to disk but the old content remains in the in-memory file_system. When a tool restart occurs later, the code in worker.rs:312-320 will use this stale in-memory content instead of reading the saved version from disk.

The original behavior of removing the file from the in-memory file system on save ensures that subsequent operations (like tool restarts) will read the up-to-date content from disk. Unless there's a guarantee that params.text is always provided, this removal should be preserved.

        let Some(worker) = workers.iter().find(|worker| worker.is_responsible_for_uri(uri)) else {
            return;
        };

        if let Some(diagnostics) = worker.run_diagnostic_on_save(uri, params.text.as_deref()).await
        {
            self.client.publish_diagnostics(uri.clone(), diagnostics, None).await;
        }
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[camc314]

Merge activity

• Dec 3, 10:28 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 3, 10:33 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
• Dec 3, 10:38 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 3, 10:44 PM UTC: Merged by the Graphite merge queue.