fix: add missing beforeInput and afterInput properties to UploadAdmin type #14775
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the missing
beforeInputandafterInputproperties to theUploadAdmintype so that the type definition reflects the actual supported admin props for upload fields.Why?
Although upload fields already support
beforeInputandafterInputin practice, these props are currently not included in theUploadAdminTypeScript type. This leads to type errors or the need for type assertions when trying to use them. Aligning the type definition with the existing runtime behavior improves DX and keeps the admin field types consistent, similar to what was done for RichTextField in #12889.How?
Extended the UploadAdmin type to include the
beforeInputandafterInputproperties.