feat: Add Web Authentication support for Android #2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
android
iOS
linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
This enables Web Authentication support on Android by adding an ability to call
setWebAuthenticationSupport(Link) on the underlying android.webkit.WebView.There are native WebAuthn integration available from AndroidX WebKit v1.12.1 or newer (Implementation Guide recommends v1.14.0) so the underlying dependency has to be updated. I noticed that #2722 also bumps the dependency version, so it might be better to merge them together.
Resolve issues #699 and #2249
Testing and Review Notes
Screenshots or Videos
To Do