-
Notifications
You must be signed in to change notification settings - Fork 26
fix: change User-Agent string product value to PascalCase #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where Web Application Firewalls (WAFs) that strictly expect PascalCase User-Agent strings were rejecting requests from rsconnect-python. The User-Agent string is changed from rsconnect-python/x.y.z to RSConnectPython/x.y.z to ensure compatibility with such WAFs.
Key changes:
- Updated the User-Agent string format from kebab-case to PascalCase
- Updated CHANGELOG to document the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rsconnect/http_support.py | Changed the _user_agent variable value from "rsconnect-python/%s" to "RSConnectPython/%s" |
| docs/CHANGELOG.md | Added entry documenting the User-Agent string format fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aronatkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do any of our other clients have a similar mistake? Should we use this opportunity to use "Posit"?
I see rsconnect uses
I think sticking with the name of the package itself makes more sense, personally |
Had the same thought. Better to rename everything all at once instead of piecemeal in my opinion. |
Fine by me. RSConnect forever! |
Intent
Some WAFs strictly expect User-Agent strings that use PascalCase, causing the previous User-Agent string (rsconnect-python) to be rejected.
Type of Change
Approach
Automated Tests
Directions for Reviewers
Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.