Skip to content

Conversation

@Aydin-ab
Copy link
Contributor

@Aydin-ab Aydin-ab commented Dec 3, 2025

Updating to a more recent release of ray where ray serve llm is more stable with vllm. Also using an anyscale image instead of a dockerfile in the anyscale service config file for gpt-oss. Previously, we used a dockerfile because there was compatibility issues with vllm but this has been fixed. Building from a dockerfile is a pretty bad experience for a user (can take ~4-5 min for the service to spin up)

…image instaed of dockerfile

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
@Aydin-ab Aydin-ab requested review from a team as code owners December 3, 2025 01:19
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Ray and vLLM versions in several documentation tutorials and switches the gpt-oss tutorial to use a pre-built Anyscale image instead of a Dockerfile, which is a great improvement for user experience.

I've found a few inconsistencies in the gpt-oss tutorial documentation (README.md and notebook.ipynb) where some values seem to have been copied from another tutorial. I've left specific comments with suggestions to fix them.

Additionally, I noticed that in the "Custom Dockerfile" examples across several of the updated markdown and notebook files, the commented-out image_uri still refers to the old version 2.49.0. While these are not part of the diff, it would be good to update them to 2.52.0 for consistency.

Overall, the changes look good and improve the documentation.

@ray-gardener ray-gardener bot added serve Ray Serve Related Issue docs An issue or change related to documentation llm labels Dec 3, 2025
Aydin-ab and others added 2 commits December 2, 2025 22:27
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Aydin Abiar <62435714+Aydin-ab@users.noreply.github.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Copy link
Contributor

@kunling-anyscale kunling-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left a few suggestions

Aydin-ab and others added 2 commits December 3, 2025 13:39
…ok.ipynb

Co-authored-by: kunling-anyscale <kunling@anyscale.com>
Signed-off-by: Aydin Abiar <62435714+Aydin-ab@users.noreply.github.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs An issue or change related to documentation llm serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants