-
Notifications
You must be signed in to change notification settings - Fork 847
fix: improve CI and helper scripts #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1803 +/- ##
=======================================
Coverage 83.90% 83.90%
=======================================
Files 115 115
Lines 13080 13080
=======================================
Hits 10975 10975
Misses 2105 2105 ☔ View full report in Codecov by Sentry. |
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamBergamin LGTM and thanks for the continued enhancements to CI 👾 ✨
I left a few comments with thoughts, but nothing that blocks this from landing sooner! 🚢 💨
| @@ -102,7 +80,6 @@ jobs: | |||
| name: Regression notifications | |||
| runs-on: ubuntu-latest | |||
| needs: | |||
| - typecheck | |||
| - unittest | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 thought: Keeping all of these workflows within this file might be nice for checking regressions for typechecks, lints, and unittests together?
🐍 ramble: Unsure of a best approach, but sharing an environment variable with the latest python version for the first of those checks might be useful if that seems like it'd be best!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 💯 I've moved the jobs in the same file
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Summary
This PR aims to improve the continuous integration pipeline by breaking up linting, typechecking and testing into separate actions.
This will allow linting and typechecking to run against the latest python and linux runtimes while allowing unit tests to run against all supported runtimes.
The helper scripts were also updated so that they can be used in the continuous integrations without installing unnecessary dependencies.
Testing
CI coverage should be sufficient, but you can run the helper scripts if you want to try them out.
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.