Skip to content

Conversation

@WilliamBergamin
Copy link
Contributor

Summary

This PR aims to improve the continuous integration pipeline by breaking up linting, typechecking and testing into separate actions.

This will allow linting and typechecking to run against the latest python and linux runtimes while allowing unit tests to run against all supported runtimes.

The helper scripts were also updated so that they can be used in the continuous integrations without installing unnecessary dependencies.

Testing

CI coverage should be sufficient, but you can run the helper scripts if you want to try them out.

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@WilliamBergamin WilliamBergamin added this to the 3.40.0 milestone Dec 2, 2025
@WilliamBergamin WilliamBergamin self-assigned this Dec 2, 2025
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner December 2, 2025 17:22
@WilliamBergamin WilliamBergamin added tests M-T: Testing work only semver:patch github_actions Pull requests that update GitHub Actions code dependencies Pull requests that update a dependency file labels Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.90%. Comparing base (4601f8a) to head (d7fc1f6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1803   +/-   ##
=======================================
  Coverage   83.90%   83.90%           
=======================================
  Files         115      115           
  Lines       13080    13080           
=======================================
  Hits        10975    10975           
  Misses       2105     2105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin LGTM and thanks for the continued enhancements to CI 👾 ✨

I left a few comments with thoughts, but nothing that blocks this from landing sooner! 🚢 💨

@@ -102,7 +80,6 @@ jobs:
name: Regression notifications
runs-on: ubuntu-latest
needs:
- typecheck
- unittest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 thought: Keeping all of these workflows within this file might be nice for checking regressions for typechecks, lints, and unittests together?

🐍 ramble: Unsure of a best approach, but sharing an environment variable with the latest python version for the first of those checks might be useful if that seems like it'd be best!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 💯 I've moved the jobs in the same file

WilliamBergamin and others added 2 commits December 5, 2025 15:17
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
@WilliamBergamin WilliamBergamin merged commit dfa5e5f into main Dec 5, 2025
16 checks passed
@WilliamBergamin WilliamBergamin deleted the improve-ci-workflows branch December 5, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code semver:patch tests M-T: Testing work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants