Skip to content

Update the copy-to-clipboard functionality in our code blocks #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update the copy-to-clipboard functionality in our code blocks #1825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions source/javascripts/app/_copy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,24 @@
function copyToClipboard(container) {
const el = document.createElement('textarea');
el.value = container.textContent.replace(/\n$/, '');
document.body.appendChild(el);
el.select();
document.execCommand('copy');
document.body.removeChild(el);
const text = container.textContent.replace(/\n$/, '');

// Use the Clipboard API
navigator.clipboard.writeText(text)
.then(() => {
// Add success feedback
const button = container.parentNode.querySelector('.copy-clipboard');
Copy link
Contributor

@realityking realityking Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to pass the button into copyToClipboard() from the event handler avoiding an extra lookup.

const originalHTML = button.innerHTML;
Copy link
Contributor

@realityking realityking Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of reading from the DOM this could be a variable also used in setupCodeCopy().


// Show success state
button.innerHTML = '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><title>Copied!</title><path d="M9 16.17L4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41L9 16.17z"></path></svg>';

// Reset after 1 second
setTimeout(() => {
button.innerHTML = originalHTML;
}, 1000);
})
.catch(err => {
console.error('Failed to copy: ', err);
});
}

function setupCodeCopy() {
Copy link
Contributor

@realityking realityking Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding some feature detection code and checking for a secure context. If one of those conditions is not met, we shouldn't show the (then non-functional) copy button.

Expand Down
Loading