-
-
Notifications
You must be signed in to change notification settings - Fork 27
Refactor the extension to use a Sphinx Domain #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
767a66b to
b1c1fc8
Compare
|
The majority of the doc updates are visible at https://sphinx-argparse--34.org.readthedocs.build/en/34/usage.html#printing-fully-qualified-sub-command-headings. PLMK if you spot some uglies. |
|
@ashb , just checking if if there's anything I can answer or do to ease the review. PLMK and thanks. |
|
Bumping this. |
- Print fully-qualified subcommand name in title - Support commands:command role for intersphinx - Prefer fully-qualified HREF targets Use targets like "#blah-sub-commands" as the primary target and move historic targets like "#Sub-commands" to secondary targets. Preserve the older HREF, `sub-commands`, as a secondary target. In the HTML, this becomes a span just below the section element so that bookmarks continue to work even after adopting the update from this commit.
|
Remaining is to resolve |
|
Thanks very, very much @AA-Turner for dusting off this PR and improving it. For your comment about confvals rather than the dictionary, is the idea that the I don't have any strong feelings and I trust your judgement. PLMK what you have in mind and I'll see what I can do. Thanks again! |
|
@AA-Turner , @mikemckiernan , @ashb EDIT: I see a rebased branch is already waiting in https://github.com/mikemckiernan/sphinx-argparse/tree/add-domain-rebase EDIT 2: I'm guessing the latest comment about no dictionaries in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cache file crept into Git here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, that's an ugly! Aside from the typo that I just noticed in the proposed change log update, the change log reflects what I hoped to accomplish.
Thanks for any help that you can provide!
| Changes | ||
|
|
||
| * Previously, common headings such as **Positional Arguments** were subject to a | ||
| process that made them unique but adding a ``_repeatX`` suffix to the HREF target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/but/by/
Uh oh!
There was an error while loading. Please reload this page.