Skip to content

Conversation

@dupdob
Copy link
Member

@dupdob dupdob commented Oct 23, 2025

Main feature: provide hints and details when project analysis fails. This is a first version that could improve via heuristics gain via user feedbacks. Current version provides hint when there is no test project detected.
This PR provides the following changes:

  • provide per project status when project analysis changed, suggestion to use the --diag option to have details
  • add a --diag command line option which supersedes --dev-mode . Behavior is the same. Option's help string has been updated to reflect actual behaviour
  • add nunit to known test framework names to handle the recent case change in the project

Fixes
Note: most of the work for this PR has been done via Rider on macOS, but tests were conduced both on macOS and Windows.

Copilot AI review requested due to automatic review settings October 23, 2025 07:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces diagnostic capabilities to help users troubleshoot project analysis failures. The main addition is a --diag command line option that supersedes --dev-mode, along with improved logging and failure hints when project analysis encounters issues.

Key Changes:

  • Adds --diag command line option with enhanced diagnostics and detailed logging
  • Provides per-project analysis status reporting with actionable suggestions
  • Adds "nunit" to known test framework names to handle recent case sensitivity changes

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
DiagModeInput.cs New input class for the diagnostic mode option
DevModeInput.cs Removed - functionality replaced by DiagModeInput
StrykerOptions.cs Renamed DevMode property to DiagMode
StrykerInputs.cs Added DiagModeInput property while maintaining DevModeInput for backward compatibility
IStrykerOptions.cs Updated interface to use DiagMode instead of DevMode
InputFileResolver.cs Enhanced logging for project analysis failures with diagnostic hints
InitialBuildProcess.cs Added platform check for .NET Framework projects
IAnalyzerResultExtensions.cs Added "nunit" to known test packages array
VsTestContextInformation.cs Updated to use DiagMode property
CsharpMutationProcess.cs Updated to use DiagMode property
CsharpCompilingProcess.cs Updated to use DiagMode property
CommandLineConfigReader.cs Added CLI registration for --diag option
LoggingInitializer.cs Updated to enable file logging in diagnostic mode
Multiple test files Updated tests to use DiagMode instead of DevMode
Comments suppressed due to low confidence (1)

src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs:1

  • The extra space before 'DiagModeInput' is inconsistent with the formatting of other lines. Remove the extra space to maintain consistent indentation.
using System;

@dupdob dupdob force-pushed the LogAnalysisOnFailure branch from 2a3135e to 05a1f12 Compare October 23, 2025 07:19
Copilot AI review requested due to automatic review settings October 23, 2025 08:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Copilot AI review requested due to automatic review settings October 23, 2025 11:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 23, 2025 11:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 23, 2025 11:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

@rouke-broersma rouke-broersma changed the title Log analysis on failure feat: Log analysis on failure Oct 24, 2025
@rouke-broersma rouke-broersma self-requested a review October 24, 2025 08:56
Copilot AI review requested due to automatic review settings October 24, 2025 16:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings October 26, 2025 10:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

@dupdob dupdob changed the title feat: Log analysis on failure Analyse Project analysis failure Nov 17, 2025
@dupdob dupdob changed the title Analyse Project analysis failure Analyse and log project(s) analysis failure Nov 17, 2025
@dupdob dupdob added Priority: Medium Issues that have a workaround or but should be fixed Area: Initialization projects identification and analysis labels Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Initialization projects identification and analysis Priority: Medium Issues that have a workaround or but should be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants