feat: use minify function exposed from Vite for Vite 8+
#5048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I was thinking to make vite 8 beta default 😅. I can push the changes. Things seems to be working fine except for manualChunks, which I think should be migrated to advancedChunks, but I saw a recent issue on rolldown that the name and API is likely be to changed? |
Contributor
Author
|
Even if we change the name & API, we'll keep the current one for a while, so it'd be fine to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vite 8+ exposes
minifyfunction so you don't need to install oxc-minify separately.Linked Issues
Additional Context
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.