Switch shutdown order from all-at-once to depth-first. #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the shutdown order of the subsystems. Previously, when Ctrl-C was received, all subsystems would simultaniously receive the shutdown signal. Now, all parent subsystems receive the shutdown signal first, then propagate the signal to their children. They also wait for their children to shutdown before shutting down themselves. This will allow us to control the order in which shutdown occurs. For example, we can wait for channels to drain before closing them, or differentiate between Ctrl-C shutdowns and error shutdowns.
This commit changes subsystem shutdown in the controller to be more careful about order and parentage to ensure we're shutting down our subsystems without writing to closed channels.
RobbieMcKinstry
commented
Jun 12, 2025
| // any state locks that we've taken before we can roll back | ||
| // the ingress or yank the platform. | ||
| relay_subsys.initiate_shutdown(); | ||
| relay_subsys.join().await?; |
Contributor
Author
There was a problem hiding this comment.
Pseudo-code.
Suggested change
| relay_subsys.join().await?; | |
| if let Err(_) = relay_subsys.join().await? { | |
| backend.shutdown_irregular(); // POST to backend to mark as errored. | |
| } |
Contributor
Author
There was a problem hiding this comment.
Also need to change the on_error to CatchAndLocalShutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the shutdown order of the subsystems.
Previously, when Ctrl-C was received, all subsystems would
simultaniously receive the shutdown signal. Now, all parent
subsystems receive the shutdown signal first, then propagate
the signal to their children. They also wait for their children
to shutdown before shutting down themselves.
This will allow us to control the order in which shutdown occurs.
For example, we can wait for channels to drain before closing them,
or differentiate between Ctrl-C shutdowns and error shutdowns.