Add AWS and Cloudflare config building to multi init
#116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RobbieMcKinstry
left a comment
RobbieMcKinstry
left a comment
There was a problem hiding this comment.
I can't review all of the files because of the GitHub outage, but I'll come back later .
| /// This is the Cloudflare account id | ||
| account_id: String, | ||
| /// The name of the Cloudflare worker | ||
| worker_name: String, |
Contributor
There was a problem hiding this comment.
Can you explain why you don't provide the worker name as a struct field anymore, and instead pass it in at each call site? I don't mean explain it in a code comment, just explain in here in PR review so I have a better understanding of the code moving forward. Thank you!
Contributor
Author
There was a problem hiding this comment.
We use the CloudflareClient in multi init now, where we're performing actions that don't have a worker name yet (ex: when we're listing all available Workers).
I remember us talking about this when building CF support and figured that we'd refactor later on.
EricGhildyal
force-pushed
the
eric/multi-682
branch
from
776513e to
d9284d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor SDK to no longer require a worker name