[breaking change] shell: Add user data argument to shell_set_bypass #100311
+73
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow passing some context to the shell bypass callback function by providing a void pointer user data argument. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
zephyrbot
added
area: Flash
area: Shell
zephyrbot
requested review from
JarmouniA,
alexanderwachter,
carlescufi,
cfriedt,
de-nordic,
henrikbrixandersen,
jakub-uC,
jukkar,
kartben,
martinjaeger,
nashif,
rghaddab,
rlubos,
ssharks and
str4t0m
jukkar
previously approved these changes
Dec 1, 2025
de-nordic
previously approved these changes
Dec 2, 2025
Contributor
de-nordic
left a comment
de-nordic
left a comment
There was a problem hiding this comment.
Flash shell changes look ok.
henrikbrixandersen
added
the
Architecture Review
henrikbrixandersen
previously approved these changes
Dec 2, 2025
Member
|
This was discussed in the Arch WG without any objections raised, see comment on #97476 (comment) |
henrikbrixandersen
removed
the
Architecture Review
ubieda
previously approved these changes
Dec 2, 2025
keith-zephyr
reviewed
Dec 2, 2025
| * @param[in] user_data Bypass callback user data. | ||
| */ | ||
| void shell_set_bypass(const struct shell *sh, shell_bypass_cb_t bypass); | ||
| void shell_set_bypass(const struct shell *sh, shell_bypass_cb_t bypass, void *user_data); |
Contributor
There was a problem hiding this comment.
Can you add a test that uses shell_set_bypass? Even a build-only test can potentially catch future API changes.
pdgendt
dismissed stale reviews from ubieda, henrikbrixandersen, de-nordic, and jukkar
via
d6d7d63
pdgendt
force-pushed
the
shell-bypass-userdata
branch
from
b30515a to
d6d7d63
Compare
zephyrbot
added
the
area: Tests
jukkar
previously approved these changes
Dec 3, 2025
Add a test to the shell testsuite for validating shell_set_bypass. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Add an entry for the shell API change for shell_set_bypass. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
pdgendt
force-pushed
the
shell-bypass-userdata
branch
from
d6d7d63 to
edcfa7e
Compare
Contributor
Author
|
Simplified the test so SonarQube doesn't block. |
jukkar
approved these changes
Dec 3, 2025
|
henrikbrixandersen
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing some context to the shell bypass callback function by providing a void pointer user data argument.
Re-submission from #97187
Fixes #97476