Desktop: Resolves: #13804: Change search Resources feature to case insensitive #13824
Conversation
…o case insensitive
| const filterLowerCase = props.filter.toLowerCase(); | ||
| return resource.title?.toLocaleLowerCase().includes(filterLowerCase) || resource.id.toLowerCase().includes(filterLowerCase); |
There was a problem hiding this comment.
Be sure to match the .toLowerCase and .toLocaleLowerCase uses. For certain system locales, .toLocaleLowerCase gives different output from .toLowerCase for the same input. For example, if the system locale is tr and props.filter is 'İ', then filterLowerCase would be 'i̇' and resource.title?.toLocaleLowerCase() would be 'i'. See also: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toLocaleLowerCase.
There was a problem hiding this comment.
Fixed 🙈 Updated the code to use toLowerCase only.
|
Just wondering, why was there a need to move the search box to the left? The ask on the issue raised was just to add a bit of space below it |
|
|
Oh I see, that last requirement merged with the image to my eyes... |
3 participants
Fixes #13804
Summary
This PR changes search functionality in Resources screen to case insensitive, adds a margin below the search field and align the search field to the left with CSS fixes for loading indicator.
Testing
resources_search_case_insensitive.mp4