-
Notifications
You must be signed in to change notification settings - Fork 45
fix: add counter to aria-describedby for screen reader accessibility #8859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/3
Are you sure you want to change the base?
fix: add counter to aria-describedby for screen reader accessibility #8859
Conversation
|
🚀 MCP preview deployed to Vercel: https://kolibri-3ki2b9ybk-public-ui-kolibri-mcp.vercel.app |
|
Netlify Draft Deployment |
|
@yurtsever - bitte erst Pipelines grün vor Review |
…s://github.com/public-ui/kolibri into merge-screen-reader-accessibility-for-textarea
deleonio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hier sind jede Menge Snaps wegen den Errors, aber nicht ein einziger wegen des Counters. Oder?
| _id: string; | ||
| _touched?: TouchedPropType; | ||
| _hideMsg?: boolean; | ||
| _hasCounter?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wozu? Wird nicht benutzt,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich habe mir das mal angeschaut. das wird benutzt. Das ist ja in dem state Objekt welches als argument übergeben wird. (state._hasCounter)
| ariaDescribedBy.push(`${state._id}-hint`); | ||
| } | ||
|
|
||
| if (state._hasCounter) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hier verwendest Du plötzlich den State?
| ariaDescribedBy.push(`${state._id}-counter`); | ||
| } | ||
|
|
||
| if (hasError === true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hat das bisher gefehlt?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das war nicht drin in v3
No description provided.