Skip to content

fix: add counter to aria-describedby for screen reader accessibility #8859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 3, 2025
Merged

fix: add counter to aria-describedby for screen reader accessibility #8859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
45f04e8
fix: add counter to aria-describedby for screen reader accessibility
yurtsever Nov 17, 2025
b4a4e3a
Merge branch 'release/3' into merge-screen-reader-accessibility-for-t…
yurtsever Nov 18, 2025
d133c2a
Merge branch 'release/3' into merge-screen-reader-accessibility-for-t…
yurtsever Nov 18, 2025
efcf726
Merge branch 'release/3' into merge-screen-reader-accessibility-for-t…
yurtsever Nov 18, 2025
2d0503b
fix: e2e test for counter
yurtsever Nov 18, 2025
a1e3f9e
Update all snapshots
yurtsever Nov 18, 2025
13e8226
feat: update snapshots
yurtsever Nov 20, 2025
87b5f2b
Merge branch 'merge-screen-reader-accessibility-for-textarea' of http…
yurtsever Nov 20, 2025
480ce1e
Merge branch 'release/3' into merge-screen-reader-accessibility-for-t…
yurtsever Nov 25, 2025
fb00a11
Merge branch 'release/3' into merge-screen-reader-accessibility-for-t…
deleonio Nov 28, 2025
e476d30
Merge branch 'release/3' into merge-screen-reader-accessibility-for-t…
deleonio Dec 2, 2025
e49c409
Merge branch 'release/3' into merge-screen-reader-accessibility-for-t…
BF150 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/components/combobox/test/__snapshots__/snapshot.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ exports[`kol-combobox should render with _label="Label" _name="field" _placehold
<div class="kol-input-container kol-input-container--error">
<div class="kol-input-container__container">
<div class="kol-combobox__group">
<input aria-autocomplete="both" aria-controls="listbox" aria-expanded="false" aria-labelledby="id-nonce" autocapitalize="off" autocorrect="off" class="kol-combobox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" placeholder="Hier steht ein Platzhaltertext" role="combobox" type="text" value="Herr">
<input aria-autocomplete="both" aria-controls="listbox" aria-describedby="id-nonce-error" aria-expanded="false" aria-labelledby="id-nonce" autocapitalize="off" autocorrect="off" class="kol-combobox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" placeholder="Hier steht ein Platzhaltertext" role="combobox" type="text" value="Herr">
<kol-button-wc _hidelabel="" _icons="codicon codicon-close" _label="kol-delete-selection" class="kol-combobox__delete" data-testid="combobox-delete"></kol-button-wc>
<kol-icon _icons="codicon codicon-triangle-down" _label="" class="kol-custom-suggestions-toggle"></kol-icon>
</div>
Expand Down
16 changes: 8 additions & 8 deletions packages/components/src/components/input-checkbox/test/__snapshots__/snapshot.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
<div class="kol-field-control__input">
<label class="kol-checkbox kol-checkbox--error kol-checkbox--touched kol-checkbox--variant-default">
<kol-icon _icons="codicon codicon-close" _label="" class="kol-checkbox__icon"></kol-icon>
<input autocapitalize="off" autocorrect="off" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocorrect="off" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
</label>
</div>
</div>
Expand Down Expand Up @@ -538,7 +538,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
<div class="kol-field-control__input">
<label class="kol-checkbox kol-checkbox--error kol-checkbox--touched kol-checkbox--variant-button">
<kol-icon _icons="codicon codicon-close" _label="" class="kol-checkbox__icon"></kol-icon>
<input autocapitalize="off" autocorrect="off" class="kol-checkbox__input kol-input kol-input--error kol-input--touched visually-hidden" id="id-nonce" name="field" type="checkbox" value="true">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocorrect="off" class="kol-checkbox__input kol-input kol-input--error kol-input--touched visually-hidden" id="id-nonce" name="field" type="checkbox" value="true">
</label>
</div>
<label class="kol-field-control__label" htmlfor="id-nonce" id="id-nonce-label">
Expand Down Expand Up @@ -881,7 +881,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
<div class="kol-field-control__input">
<label class="kol-checkbox kol-checkbox--error kol-checkbox--touched kol-checkbox--variant-switch">
<kol-icon _icons="codicon codicon-close" _label="" class="kol-checkbox__icon"></kol-icon>
<input autocapitalize="off" autocorrect="off" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocorrect="off" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
</label>
</div>
<label class="kol-field-control__label" htmlfor="id-nonce" id="id-nonce-label">
Expand Down Expand Up @@ -1231,7 +1231,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
<div class="kol-field-control__input">
<label class="kol-checkbox kol-checkbox--checked kol-checkbox--error kol-checkbox--touched kol-checkbox--variant-default">
<kol-icon _icons="codicon codicon-check" _label="" class="kol-checkbox__icon"></kol-icon>
<input autocapitalize="off" autocorrect="off" checked="" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocorrect="off" checked="" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
</label>
</div>
</div>
Expand Down Expand Up @@ -1567,7 +1567,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
<div class="kol-field-control__input">
<label class="kol-checkbox kol-checkbox--checked kol-checkbox--error kol-checkbox--touched kol-checkbox--variant-default">
<kol-icon _icons="codicon codicon-check" _label="" class="kol-checkbox__icon"></kol-icon>
<input autocapitalize="off" autocorrect="off" checked="" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocorrect="off" checked="" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
</label>
</div>
<label class="kol-field-control__label" htmlfor="id-nonce" id="id-nonce-label">
Expand Down Expand Up @@ -1910,7 +1910,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
<div class="kol-field-control__input">
<label class="kol-checkbox kol-checkbox--checked kol-checkbox--error kol-checkbox--touched kol-checkbox--variant-button">
<kol-icon _icons="codicon codicon-check" _label="" class="kol-checkbox__icon"></kol-icon>
<input autocapitalize="off" autocorrect="off" checked="" class="kol-checkbox__input kol-input kol-input--error kol-input--touched visually-hidden" id="id-nonce" name="field" type="checkbox" value="true">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocorrect="off" checked="" class="kol-checkbox__input kol-input kol-input--error kol-input--touched visually-hidden" id="id-nonce" name="field" type="checkbox" value="true">
</label>
</div>
<label class="kol-field-control__label" htmlfor="id-nonce" id="id-nonce-label">
Expand Down Expand Up @@ -2253,7 +2253,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
<div class="kol-field-control__input">
<label class="kol-checkbox kol-checkbox--checked kol-checkbox--error kol-checkbox--touched kol-checkbox--variant-switch">
<kol-icon _icons="codicon codicon-check" _label="" class="kol-checkbox__icon"></kol-icon>
<input autocapitalize="off" autocorrect="off" checked="" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocorrect="off" checked="" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="checkbox" value="true">
</label>
</div>
<label class="kol-field-control__label" htmlfor="id-nonce" id="id-nonce-label">
Expand Down Expand Up @@ -2596,7 +2596,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
<div class="kol-field-control__input">
<label class="kol-checkbox kol-checkbox--error kol-checkbox--indeterminate kol-checkbox--touched kol-checkbox--variant-default">
<kol-icon _icons="codicon codicon-remove" _label="" class="kol-checkbox__icon"></kol-icon>
<input autocapitalize="off" autocorrect="off" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" indeterminate="" name="field" type="checkbox" value="true">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocorrect="off" class="kol-checkbox__input kol-input kol-input--error kol-input--touched" id="id-nonce" indeterminate="" name="field" type="checkbox" value="true">
</label>
</div>
<label class="kol-field-control__label" htmlfor="id-nonce" id="id-nonce-label">
Expand Down
8 changes: 4 additions & 4 deletions packages/components/src/components/input-color/test/__snapshots__/snapshot.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,8 @@ exports[`kol-input-color should render with _label="Label" _name="field" _placeh
<div class="kol-input-container kol-input-container--error">
<div class="kol-input-container__container">
<div class="kol-input-color__inputs-wrapper">
<input aria-hidden="true" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched kol-input-color__input kol-input-color__input--color" name="field-color" tabindex="-1" type="color" value="#FFF">
<input autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched kol-input-color__input kol-input-color__input--text" id="id-nonce" name="field-text" type="text" value="#FFF">
<input aria-describedby="id-nonce-error" aria-hidden="true" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched kol-input-color__input kol-input-color__input--color" name="field-color" tabindex="-1" type="color" value="#FFF">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched kol-input-color__input kol-input-color__input--text" id="id-nonce" name="field-text" type="text" value="#FFF">
</div>
</div>
</div>
Expand Down Expand Up @@ -550,8 +550,8 @@ exports[`kol-input-color should render with _label="Label" _name="field" _placeh
<div class="kol-input-container kol-input-container--error">
<div class="kol-input-container__container">
<div class="kol-input-color__inputs-wrapper">
<input aria-hidden="true" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched kol-input-color__input kol-input-color__input--color" list="id-nonce-list" name="field-color" tabindex="-1" type="color" value="#FFF">
<input autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched kol-input-color__input kol-input-color__input--text" id="id-nonce" list="id-nonce-list" name="field-text" type="text" value="#FFF">
<input aria-describedby="id-nonce-error" aria-hidden="true" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched kol-input-color__input kol-input-color__input--color" list="id-nonce-list" name="field-color" tabindex="-1" type="color" value="#FFF">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched kol-input-color__input kol-input-color__input--text" id="id-nonce" list="id-nonce-list" name="field-text" type="text" value="#FFF">
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/input-date/test/__snapshots__/snapshot.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ exports[`kol-input-date should render with _label="Label" _name="field" _placeho
<div class="kol-form-field__input">
<div class="kol-input-container kol-input-container--error">
<div class="kol-input-container__container">
<input autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" max="9999-12-31" name="field" type="date" value="2025-01-01">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" max="9999-12-31" name="field" type="date" value="2025-01-01">
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/input-email/test/__snapshots__/snapshot.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ exports[`kol-input-email should render with _label="Label" _name="field" _placeh
<div class="kol-form-field__input">
<div class="kol-input-container kol-input-container--error">
<div class="kol-input-container__container">
<input autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" placeholder="Hier steht ein Platzhaltertext" type="email" value="email@example.com">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" placeholder="Hier steht ein Platzhaltertext" type="email" value="email@example.com">
</div>
</div>
</div>
Expand Down Expand Up @@ -530,7 +530,7 @@ exports[`kol-input-email should render with _label="Label" _name="field" _placeh
<div class="kol-form-field__input">
<div class="kol-input-container kol-input-container--error">
<div class="kol-input-container__container">
<input autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" list="id-nonce-list" name="field" placeholder="Hier steht ein Platzhaltertext" type="email" value="email@example.com">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" list="id-nonce-list" name="field" placeholder="Hier steht ein Platzhaltertext" type="email" value="email@example.com">
<datalist id="id-nonce-list">
<option value="email1@example.com"></option>
<option value="email2@example.com"></option>
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/input-file/test/__snapshots__/snapshot.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ exports[`kol-input-file should render with _label="Label" _name="field" _placeho
<span class="kol-input-container__filename">
kol-filename-text
</span>
<input autocapitalize="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="file">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" type="file">
<kol-button-wc _buttonvariant="primary" _label="kol-data-browse-text" class="kol-input-container__button"></kol-button-wc>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/input-number/test/__snapshots__/snapshot.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ exports[`kol-input-number should render with _label="Label" _name="field" _place
<div class="kol-form-field__input">
<div class="kol-input-container kol-input-container--error">
<div class="kol-input-container__container">
<input autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" placeholder="Hier steht ein Platzhaltertext" type="number">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" placeholder="Hier steht ein Platzhaltertext" type="number">
</div>
</div>
</div>
Expand Down Expand Up @@ -530,7 +530,7 @@ exports[`kol-input-number should render with _label="Label" _name="field" _place
<div class="kol-form-field__input">
<div class="kol-input-container kol-input-container--error">
<div class="kol-input-container__container">
<input autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" list="id-nonce-list" name="field" placeholder="Hier steht ein Platzhaltertext" type="number">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" list="id-nonce-list" name="field" placeholder="Hier steht ein Platzhaltertext" type="number">
<datalist id="id-nonce-list">
<option value="1"></option>
<option value="2"></option>
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/input-password/test/__snapshots__/snapshot.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ exports[`kol-input-password should render with _label="Label" _name="field" _pla
<div class="kol-form-field__input">
<div class="kol-input-container kol-input-container--error">
<div class="kol-input-container__container">
<input autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" placeholder="Hier steht ein Platzhaltertext" type="password" value="Value">
<input aria-describedby="id-nonce-error" autocapitalize="off" autocomplete="off" autocorrect="off" class="kol-input kol-input--error kol-input--touched" id="id-nonce" name="field" placeholder="Hier steht ein Platzhaltertext" type="password" value="Value">
</div>
</div>
</div>
Expand Down
Loading
Loading